Re: [PATCH] population bug in create()?

[prev] [thread] [next] [Date index for 2004/10/19]

On Tue, Oct 19, 2004 at 05:24:21PM +0900, Tatsuhiko Miyagawa wrote:
> 519:   if (@primary_columns == grep defined, @{$data}{@primary_columns})
> grep defined, @{$data}{qw(id)} automatically populates id => undef on
> $data hashref. So here's a patch.
> 
> - if (@primary_columns == grep defined, @{$data}{@primary_columns}) {
> + my $num = 0;
> + for my $pk (@primary_columns) {
> +     $num++ if defined $data->{$pk};
> + }
> + if (@primary_columns == $num) {

Ouch.

I'm curious if there isn't a better way here, though...

Thanks,

Tony