Re: possible Class::DBI::Oracle [patch]

[prev] [thread] [next] [Date index for 2005/04/22]

Just a couple of nit picks, why not :)

> --- Oracle.pm.orig	2003-07-15 19:56:23.000000000 -0500
> +++ Oracle.pm	2005-04-21 16:09:07.000000000 -0500
> @@ -16,6 +16,15 @@
> +
> +        my $cdbi_table;
> +
> +        if ($table =~ /\./ and not $schema) {

If someone sends in a "schema.tablename", this has to be true otherwise 
you should raise an error.  (or I suppose you could go on further and 
make sure that the schemas are == )

> +            $cdbi_table = $table;
> +            ($schema, $table) = split(/\./, $cdbi_table);
> +        }
> +        elsif ($schema) {
> +            $cdbi_table = join('.', $schema, $table);
> +        }
> +        else {
> +            $schema ||= $dbh->{Username};
> +            $cdbi_table = $table;
> +        }
> +
> +	$class->table($cdbi_table);
>  
> +        # upper-case here for backward compatibility with 0.51?
> +        # convenience?
>  	$table = uc $table;
> +        $schema = uc $schema;

I put in the, uc $table, just for searching the oracle catalog, since 
that is obsolete, its probably not needed.