Re: mp2: Make test fails...

[prev] [thread] [next] [Date index for 2004/11/23]

Greg Freiter wrote:
[...]
> waiting 120 seconds for server to start: .[Sun Nov 21 16:23:06 2004]
> [info] 26
> 
> Apache:: modules loaded
> 
> [Sun Nov 21 16:23:06 2004] [info] 7 APR:: modules loaded
> 
> [Sun Nov 21 16:23:06 2004] [info] base server + 26 vhosts ready to run
> tests
> 
> [Sun Nov 21 16:23:06 2004] [error] Insecure directory in $ENV{PATH}
> while
> 
> running with -T switch at
> 
> /alternative/dev/mod_perl-1.99_17/Apache-Test/lib/Apache/TestConfig.pm
> line
> 
> 1035.

Greg, in file Apache-Test/lib/Apache/TestConfig.pm:

sub open_cmd {
     my($self, $cmd) = @_;
     # untaint some %ENV fields
     local @ENV{ qw(IFS CDPATH ENV BASH_ENV) };

     # Temporarly untaint PATH
     (local $ENV{PATH}) = ( $ENV{PATH} =~ /(.*)/ );
     # -T disallows relative directories in the PATH
     $ENV{PATH} = join ':', grep !/^\./, split /:/, $ENV{PATH};

     my $handle = Symbol::gensym();
     open $handle, "$cmd|" or die "$cmd failed: $!";

     return $handle;
}

please dump the value of $ENV{PATH} just before open() is called, run 
'make test' again and post the printed value here (it should appear just 
before the error).

e.g. add the print line, like so:

     $ENV{PATH} = join ':', grep !/^\./, split /:/, $ENV{PATH};
     print STDERR "PATH: $ENV{PATH}\n";

thanks.

        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html