Re: [A-T patch] changing should_skip_module to support regex skip patterns

[prev] [thread] [next] [Date index for 2005/01/07]

 >-------- Оригинално писмо --------
 >От:  Stas Bekman <stas@xxxxxx.xxx>
 >Относно: Re: [A-T patch] changing should_skip_module to support regex skip
 patterns
 >До: test-dev@xxxxx.xxxxxx.xxx
 >Изпратено на: Четвъвтък, 2005, Януари 6 20:39:39 EET
 >----------------------------------
 >
 >Geoffrey Young wrote:
 >> 
 >> Stas Bekman wrote:
 >> 
 >>>As you can see from the email below, some modules embed a version number
 >>>in the module 'mod_fastcgi-2.4.2-AP20.dll'. Our should_skip_module only
 >>>matches an exact name. The patch at the end of this email extends the
 >>>functionality to support regex skip arguments. Let me know if you have
 >>>any objections to this change.
 >> 
 >> 
 >> +1
 >> 
 >> 
 >>>+        $name =~ s/\.(s[ol]|dll)$/.c/;  #mod_info.so => mod_info.c
 >>>+        $name =~ s/\.dll$/.c/;  #mod_info.so => mod_info.c
 >
 >Thanks for the catch. How about this:
 >
 >Index: lib/ModPerl/TestRun.pm
 >===================================================================
 >--- lib/ModPerl/TestRun.pm	(revision 124346)
 >+++ lib/ModPerl/TestRun.pm	(working copy)
 >@@ -64,12 +64,9 @@
 >[...]
 >  1;
 >Index: Apache-Test/lib/Apache/TestConfigParse.pm
 >===================================================================
 >--- Apache-Test/lib/Apache/TestConfigParse.pm	(revision 124346)
 >+++ Apache-Test/lib/Apache/TestConfigParse.pm	(working copy)
 >@@ -162,20 +162,28 @@
 >[...]
 >
 >          $name = $modname_alias{$name} if $modname_alias{$name};

Works fine.


-----------------------------------------------------------------
Активирайте SMS известяване за получено писмо - http://promo.abv.bg/new_sms.html