Re: unexpected Apache::VMonitor output

[prev] [thread] [next] [Date index for 2005/01/22]

Todd Finney wrote:
> At 05:30 PM 1/21/2005 -0500, Stas Bekman wrote:
> 
>> Any chance you could compare the logic of mod_status and 
>> Apache::VMonitor and see why there is a difference?
> 
> 
> Let me get my stick and turn off the lights.
> 
>> I'd suspect that what you see is some process IDs that used to be use 
>> by Apache but now re-used by the OS, and the scoreboard gives the 
>> stale info.
> 
> 
> Unlikely.  The errant processes all seem to be daemontools programs like 
> supervise and svcscanboot.  Those processes are started long before 
> apache starts, and they exist until after it goes away.

Understood. In which case I don't know what the problem is. I'd have been 
more helpful if I could reproduce it here.

>> I see that mod_status has all kind of  freshness checks. May be 
>> Apache::VMonitor should do the same?
>  
> It couldn't hurt.

So when you compare the two, feel free to backport the relevant freshness 
checks over to A-VM and post a patch to me/here.

>> I've just released Apache::Scoreboard 0.12 which exposes the vhost 
>> record for mod_perl 1, and the newly released Apache::VMonitor 2.02 
>> uses that information.
> 
> 
> VMonitor 2.02's `make test` is complaining loudly most of the time, 
> failing tests 3-6.  It managed to succeed once, though.   If I go ahead 
> and install it anyway, pulling up the VMonitor page causes the process 
> to segfault.

Ouch. Most likely it was introduced by Apache-Scoreboard's last change. 
Please try with this patch:

Index: Scoreboard.xs
===================================================================
--- Scoreboard.xs       (revision 122)
+++ Scoreboard.xs       (working copy)
@@ -31,8 +31,10 @@
  #define server_score_conn_count(s)      s->record.conn_count
  #define server_score_client(s)          s->record.client
  #define server_score_request(s)         s->record.request
-#define server_score_vhost(s)           s->record.vhostrec->server_hostname

+#define server_score_vhost(s) \
+    s->record.vhostrec ? s->record.vhostrec->server_hostname : ""
+
  #define parent_score_pid(s) s->record.pid

  static scoreboard *my_scoreboard_image = NULL;



if it doesn't help, please post the backtrace of the core.

        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com