Re: minor bugfix for Apache::Test

[prev] [thread] [next] [Date index for 2005/01/26]

--nextPart5341825.J13hDAF5IE
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

On Wednesday 26 January 2005 13:42, Geoffrey Young wrote:
> Torsten Foertsch wrote:
> > Hi,
> >
> > while trying out Apache-IncludeHook-2.00_02
>
> I haven't touched that in a while, so if you see it failing to work on
> newish apache just holler.  other than that, I hope you like it :)

Yes, since 10 May 2004. So, I was expecting some problems.
>
> > I stumbled across the lack of
> > Apache::Test::have().
>
> hmm... is have() really required?

No, it isn't. Here is a patch to Apache-IncludeHook-2.00_02. BTW, what does=
=20
need { 'subrequests under construction' =3D> 0 } mean?

Another question, where should the include files reside? On my system they =
are installed at
/usr/include/apache2/modules/perl/mod_perl.h and /usr/include/apache2/mod_i=
nclude.h.=20
Is that correct?

Torsten

diff -Naur Apache-IncludeHook-2.00_02/IncludeHook.xs Apache-IncludeHook-2.0=
0_02.new/IncludeHook.xs
=2D-- Apache-IncludeHook-2.00_02/IncludeHook.xs	2004-05-10 20:37:26.0000000=
00 +0200
+++ Apache-IncludeHook-2.00_02.new/IncludeHook.xs	2005-01-25 20:50:37.00000=
0000 +0100
@@ -2,8 +2,8 @@
 #include "perl.h"
 #include "XSUB.h"
=20
=2D#include "mod_perl.h"
=2D#include "mod_include.h"
+#include <modules/perl/mod_perl.h>
+#include <mod_include.h>
=20
 #define REFCNT_AND_ERROR(buffer,obj,av,hv,rv) \
   MP_TRACE_f(MP_FUNC, "final reference counts: buffer=3D%d, obj=3D%d, av=
=3D%d, hv=3D%d\n", \
@@ -46,7 +46,7 @@
   server_rec  *s     =3D r->server;
   apr_pool_t  *p     =3D r->pool;
=20
=2D  modperl_handler_t  *handler;
+  modperl_handler_t  *handler=3D0;
   apr_bucket         *tmp_buck;
   apr_bucket         *b_new;
   apr_bucket_brigade *bb_new;
diff -Naur Apache-IncludeHook-2.00_02/t/05perl-subreq.t Apache-IncludeHook-=
2.00_02.new/t/05perl-subreq.t
=2D-- Apache-IncludeHook-2.00_02/t/05perl-subreq.t	2004-05-10 18:01:52.0000=
00000 +0200
+++ Apache-IncludeHook-2.00_02.new/t/05perl-subreq.t	2005-01-26 14:10:59.89=
8868917 +0100
@@ -9,10 +9,10 @@
=20
 # tests for handlers that run subrequests
=20
=2Dplan tests =3D> 5, (have_lwp &&
=2D                  have_module('mod_perl.c') &&
=2D                  have_module('include') &&
=2D                  have { 'subrequests under construction' =3D> 0 } );
+plan tests =3D> 5, (need_lwp &&
+                  need_module('mod_perl.c') &&
+                  need_module('include') &&
+                  need { 'subrequests under construction' =3D> 0 } );
=20
 t_write_file(catfile('htdocs', 'flat.shtml'),=20
              '<!-- #echo var=3D"INCLUDE_HOOK" -->');

--nextPart5341825.J13hDAF5IE
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQBB95mPwicyCTir8T4RAuxEAKC4/IVGikuceUrk8kuMfJgdXFrnfQCgy8N+
Pi2dnKmOK2eEyh3zLjKsOes=
=ULL2
-----END PGP SIGNATURE-----

--nextPart5341825.J13hDAF5IE--