Re: [mp2] DESTDIR does not apply to mod_perl.so and includes

[prev] [thread] [next] [Date index for 2005/02/08]

Frederic LE GUERN wrote:
> ${source_dir}/src/modules/perl/Makefile does not reference $(DESTDIR) in
> install: rule, so when trying to make mod_perl2 as a relocatable package
> mod_perl.so and mod_perl .h files get installed system-wide.
> 
> Here's a patch :
> 
> --- Makefile.orig    2005-02-08 00:43:50.000000000 +0000
> +++ Makefile    2005-02-08 00:32:12.000000000 +0000
> @@ -101,12 +101,12 @@
> 
>  install:
>  # install mod_perl.so
> -       @$(MKPATH) $(MODPERL_AP_LIBEXECDIR)
> +       @$(MKPATH) $(DESTDIR)/$(MODPERL_AP_LIBEXECDIR)
>         $(MODPERL_TEST_F) $(MODPERL_LIB_DSO) && \
> -       $(MODPERL_CP) $(MODPERL_LIB_DSO) $(MODPERL_AP_LIBEXECDIR)
> +       $(MODPERL_CP) $(MODPERL_LIB_DSO) $(DESTDIR)/$(MODPERL_AP_LIBEXECDIR)
>  # install mod_perl .h files
> -       @$(MKPATH) $(MODPERL_AP_INCLUDEDIR)
> -       $(MODPERL_CP) $(MODPERL_H_FILES) $(MODPERL_AP_INCLUDEDIR)
> +       @$(MKPATH) $(DESTDIR)/$(MODPERL_AP_INCLUDEDIR)
> +       $(MODPERL_CP) $(MODPERL_H_FILES) $(DESTDIR)/$(MODPERL_AP_INCLUDEDIR)
> 
>  .SUFFIXES: .xs .c $(MODPERL_OBJ_EXT) .lo .i .s

I understand that you are trying to solve the packager's problem, but I 
think this is going to break things for the rest of the world, no?

Also I suppose that your patch just illustrates the issue, since Makefiles 
are autogenerated.

        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com