Re: [BUG MP1/MP2] Apache should bail out in case of syntax errors in <Perl> section

[prev] [thread] [next] [Date index for 2005/03/10]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Philippe M. Chiasson a écrit :

| I've identified the source of the problem I believe, so can you try
|  this patch and let me know if it works for you?

Works! BTW, your patch was defective but Emacs' diff-mode fixed that
in no time. Therefore I'm re-attaching it for the record.

Index: src/modules/perl/modperl_cmd.c
===================================================================
- --- src/modules/perl/modperl_cmd.c      (revision 156679)
+++ src/modules/perl/modperl_cmd.c      (working copy)
@@ -554,8 +554,8 @@
~         ENTER;SAVETMPS;
~         save_scalar(gv); /* local $0 */
~         sv_setpv_mg(GvSV(gv), directive->filename);
- -        eval_pv(arg, FALSE);
+        eval_sv(newSVpv(arg, 0), G_KEEPERR);
~         modperl_env_sync_srv_env_hash2table(aTHX_ p, scfg);
~         modperl_env_sync_dir_env_hash2table(aTHX_ p, dcfg);
~         FREETMPS;LEAVE;
~     }



- --
Dominique QUATRAVAUX                           Ingénieur senior
01 44 42 00 08                                 IDEALX

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCMCYHMJAKAU3mjcsRAk8eAKCAfbZN1rogA93cUoICoZKeLf/1jgCZAec1
wt5TiLbE9xZ3r9FVucJriF0=
=mJvs
-----END PGP SIGNATURE-----