Re: [BUG] line numbering off-by-one with Apache::DB and RegistryCooker

[prev] [thread] [next] [Date index for 2005/03/15]

--fUYQa+Pmc3FrFX/N
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

> Thanks, Dominique. But care to post a unified patch? 'diff -u'
> Thanks!

Actually it was one, but Thunderbird munged it :-(. Retrying with
mutt... Sorry for yet another blunder.

Index: ModPerl-Registry/lib/ModPerl/RegistryCooker.pm
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D
--- ModPerl-Registry/lib/ModPerl/RegistryCooker.pm	(revision 157426)
+++ ModPerl-Registry/lib/ModPerl/RegistryCooker.pm	(working copy)
@@ -556,7 +556,9 @@
 # func: rewrite_shebang
 # dflt: rewrite_shebang
 # desc: parse the shebang line and convert command line switches
-#       (defined in %switches) into a perl code.
+#       (defined in %switches) into a perl code. This routine must
+#       not shange the number of lines in the script, lest the #line
+#       statement be off-by-one in convert_script_to_compiled_handler().
 # args: $self - registry blessed object
 # rtrn: nothing
 # efct: the CODE field gets adjusted
@@ -569,7 +571,7 @@
              unless ${^TAINT};
        "";
    },
-   'w' =3D> sub { "use warnings;\n" },
+   'w' =3D> sub { "use warnings; " },
 );
=20
 sub rewrite_shebang {


--=20
Dominique QUATRAVAUX                           Ing=E9nieur senior
01 44 42 00 08                                 IDEALX


--fUYQa+Pmc3FrFX/N
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.5 (GNU/Linux)

iD8DBQFCNqI4MJAKAU3mjcsRAgdCAKCX5Tr8O/vx6y1sEaPKCWdkxCXnoQCghAY6
OKKFKOelfJjr22PiVg3+7Xw=
=3L5X
-----END PGP SIGNATURE-----

--fUYQa+Pmc3FrFX/N--