Re: Pushing OutputHandler using PerlFixupHandler

[prev] [thread] [next] [Date index for 2005/03/21]

Tom Schindl wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Geoffrey Young wrote:
> |>    $r->push_handlers(
> |>          PerlOutputFilterHandler =>
> |>          \&Beso::OutFilterHandler::handler
[...]
> Nope. Browsing the docs I found this which is working:
> 
> - ---------------8<---------------
> use Apache::Filter();
> 
> ....
> $r->add_output_filter( \&Beso::OutFilterHandler::handler );
> ....
> - ---------------8<---------------
> 
> Is the above really supposed to work?

($r|$c)->add_*_filter is the right API, documented at:
http://perl.apache.org/docs/2.0/api/Apache/Filter.html#Other_Filter_related_API

I suppose it'd be nice to mention those in 
http://perl.apache.org/docs/2.0/user/handlers/filters.html
patches are welcome :)

While we could make the add_*_filter API work similar to push handlers, we 
better not do that, since we can't implement the remaining parallel 
mod_perl handler APIs, i.e., set, unset, etc. since those aren't under 
full control of mod_perl (since other modules + core add filters too).


        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com