Re: mod_perl.c:61: `my_perl' undeclared under Cygwin

[prev] [thread] [next] [Date index for 2005/03/25]

From: Stas Bekman
Subject: Re: mod_perl.c:61: `my_perl' undeclared under Cygwin
Date: 22:42 on 25 Mar 2005
Nick *** wrote:

> I've attached my patch (which includes yours too). With this patch MP2
> now builds fine under Cygwin and almost all tests pass (the ones that fail
> are related to the MP_STATIC_EXTS=1 option).

Great news, Nick!

> I don't know if this is a good fix. I saw it in another application,
> which had the same problem under Cygwin.

> -static XS(MPXS_apr_uuid_format)
> +#ifndef CYGWIN
> +static
> +#endif
> +XS(MPXS_apr_uuid_format)
>  {
>      dXSARGS;

We can do that. But it should be done in one place and not repeated in all 
files. So could you apply this patch:

Index: src/modules/perl/modperl_common_util.h
===================================================================
--- src/modules/perl/modperl_common_util.h      (revision 158965)
+++ src/modules/perl/modperl_common_util.h      (working copy)
@@ -25,6 +25,12 @@
  #define MP_INLINE APR_INLINE
  #endif

+#ifdef CYGWIN
+#define MP_STATIC
+#else
+#define MP_STATIC static
+#endif
+
  #ifdef WIN32
  #   define MP_FUNC_T(name)          (_stdcall *name)
  #   define MP_FUNC_NONSTD_T(name)   (*name)

and then s/static/MP_STATIC/ in all the places you have a problem with and 
resubmit a new patch?

Thanks.



        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

mod_perl.c:61: `my_perl' undeclared under Cygwin
sdfgsd sergserg 11:44 on 13 Dec 2004

Re: mod_perl.c:61: `my_perl' undeclared under Cygwin
sdfgsd sergserg 15:00 on 13 Dec 2004

Re: mod_perl.c:61: `my_perl' undeclared under Cygwin
sdfgsd sergserg 17:32 on 14 Dec 2004

Re: mod_perl.c:61: `my_perl' undeclared under Cygwin
Philippe M. Chiasson 04:31 on 31 Jan 2005

Re: mod_perl.c:61: `my_perl' undeclared under Cygwin
Stas Bekman 22:42 on 25 Mar 2005

Generated at 14:43 on 11 Apr 2005 by mariachi v0.52