Re: [mp2] [PATCH] implement ap_save_brigade

[prev] [thread] [next] [Date index for 2005/05/09]

From: Dorian Taylor
Subject: Re: [mp2] [PATCH] implement ap_save_brigade
Date: 22:21 on 09 May 2005

> How is that related?

i think that's some cargo culting that i didn't clean up. that can
be disregarded.

> So you think this approach will be faster than flattening bb on each 
> filter invocation and concatenating the scalar?

honestly i didn't give it any thought. when i wrote this i just
wanted to make it go.

> sub Apache::SubRequest::run_trapped {
>     my ($r, $sref) = @_;
> [...]
>     $bb->flatten(my $data);
>     $$sref = $data;
>     $rv;
> 
> why not make the API that does run_trapped($data) and save the copying of 
> what could be a huge data with:
> 
> sub Apache::SubRequest::run_trapped {
>     my $r = shift;
> [...]
>     $bb->flatten($_[1]);

yeah that makes significantly more sense. i'll update that soon.

.d

(message missing)

[mp2] [PATCH] implement ap_save_brigade
Dorian Taylor 18:22 on 09 May 2005

Decaying Performance under newer apache/mp versions
J.e. Turcotte 19:22 on 09 May 2005

Re: Decaying Performance under newer apache/mp versions
Gedanken 19:33 on 09 May 2005

Re: Decaying Performance under newer apache/mp versions
J.e. Turcotte 20:07 on 09 May 2005

Re: Decaying Performance under newer apache/mp versions
Ricardo Ramos Massaro 20:08 on 09 May 2005

Re: Decaying Performance under newer apache/mp versions
Perrin Harkins 20:36 on 09 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Stas Bekman 21:37 on 09 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Dorian Taylor 22:21 on 09 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Stas Bekman 23:00 on 09 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Dorian Taylor 23:30 on 09 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Stas Bekman 01:31 on 10 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Stas Bekman 05:13 on 13 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Dorian Taylor 19:48 on 17 May 2005

Re: [mp2] [PATCH] implement ap_save_brigade
Stas Bekman 19:51 on 17 May 2005