Re: [MP2] 1.999024 fails on OS X

[prev] [thread] [next] [Date index for 2005/05/15]

This is an OpenPGP/MIME signed message (RFC 2440 and 3156)
--------------enigB20F7E2844195A7F322DE7EA
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Christian Hansen wrote:
> Philippe M. Chiasson wrote:
> 
>>
>> Just rebuilt myself a fresh blead-perl, fresh httpd-2.0-svn and
>> mod_perl-2.0-svn. All tests passed!
>>
>> My hunch is that's it's something about Apple's Perl, and I'll
>> investigate
>> more later on. For now, I guess the best advice is to try with a
>> self-built
>> Perl and see if that hepls.
> 
> 
> I have tested with perl 5.8.5, 5.8.6 with ithreads which fails, and
> 5.8.6 without ithreads which works. All built by myself.
> 
> I have no problems with MP 1.999.21 with ithreads, so my guess is that
> something changed after 1.999.21.
> 

After a long promised investigation session, I believe I have pinned
it down. It seems to have been introduced by change r160562 when the
anon_cnt initialization code was moved around as a result. Didn't have
enough time tonight to dig down as to _why_ this is breaking though...

Not entirely sure why this breaks specifically on Darwin and all, but
the following patch seems to make the problem dissapear. Does it fix
the problem you are seeing too ?

Index: src/modules/perl/modperl_handler.c
===================================================================
--- src/modules/perl/modperl_handler.c  (revision 170139)
+++ src/modules/perl/modperl_handler.c  (working copy)
@@ -89,9 +89,6 @@
         modperl_modglobal_lookup(aTHX_ "ANONSUB");
     MP_TRACE_h(MP_FUNC, "init $PL_modglobal{ANONSUB} = []");
     MP_MODGLOBAL_STORE_HV(gkey);
-
-    /* init the counter to 0 */
-    modperl_global_anon_cnt_init(p);
 }

 /* allocate and populate the anon handler sub-struct */
Index: src/modules/perl/mod_perl.c
===================================================================
--- src/modules/perl/mod_perl.c (revision 170139)
+++ src/modules/perl/mod_perl.c (working copy)
@@ -532,6 +532,9 @@
     modperl_global_init_server_rec(pconf, s);

     modperl_tls_create_request_rec(pconf);
+
+    /* init the counter to 0 */
+    modperl_global_anon_cnt_init(pconf);
 }

 /*


--------------enigB20F7E2844195A7F322DE7EA
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (Darwin)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCh2rIyzKhB4jDpaURAzF3AJ9f5C2Ky1QgSE68VVxUz7dZFouB6QCeIlIb
Xr79zfx5lqxcIDDfYdFIO9U=
=hR7m
-----END PGP SIGNATURE-----

--------------enigB20F7E2844195A7F322DE7EA--