Re: [MP2] : REDIRECT_ERROR_NOTES not set on errordocument redirect

[prev] [thread] [next] [Date index for 2005/05/23]

Mark wrote:
[...]
>> Could it possibly come from here?
>>
>> src/modules/perl/modperl_callback.c
>>
>>     if (status == HTTP_INTERNAL_SERVER_ERROR) {
>>         if (r && r->notes) {
>>             apr_table_set(r->notes, "error-notes", SvPV_nolen(ERRSV));
>>         }
>>     }
>>
>> And we should check whether error-notes is already set and append the 
>> error instead?
> 
> 
> Yes, this appears to be the culprit.  Based on my glance at apr_tables.h,
> I concluded this was the right thing to do, and it works:
> 
> - apr_table_set(r->notes, "error-notes", SvPV_nolen(ERRSV));
> + apr_table_mergen(r->notes, "error-notes", SvPV_nolen(ERRSV));
> 
> (I did this on 2.0.0 release)

Thanks Mark, committed.


        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com