Re: [Templates] Announce: CGI::Builder::TT2 0.01

[prev] [thread] [next] [Date index for 2004/06/21]

>>>>> "Stefano" == Stefano Rodighiero <stefano.rodighiero@xxxxxxx.xx> writes:

Stefano> I just uploaded CGI::Builder::TT2 to CPAN.
Stefano> A big 'THANK YOU' to Domizio Demichelis, and to Vince Veselosky.

Ow.  Exactly as I feared when I saw the dreaded "Domizio" there.

You have this in your Makefile.PL:

    my (%opt) = map { split /=/ } @ARGV;
    exit if $opt{ NO_VERSION_CHECK };

    my $LWP_installed = eval { require LWP::Simple };

    if ($LWP_installed) {

        my $curr_vers = LWP::Simple::get( "http://perl.4pro.net/version_check";
                                        . "?DISTRIBUTION=$dist"
                                        . "&VERSION=$vers"
                                        . "&PERL=$]-$^O" );

        exit unless defined $curr_vers;
    [...]

PLEASE REMOVE THIS AT ONCE.

Makefile.PLs should *not* "phone home" by default.
Your command-line check is reversed.  Please make it so you need
to add "VERSION_CHECK=xxx" to the command line before you "phone home".

Please.  I've already personally blacklisted DOMIZIO's modules
from my CPAN archive.  Don't make me blacklist yours as well.

        -- 
        Randal L. Schwartz - Stonehenge Consulting Services, Inc. - +1 503 777 0095
<merlyn@xxxxxxxxxx.xxx> <URL:http://www.stonehenge.com/merlyn/>
Perl/Unix/security consulting, Technical writing, Comedy, etc. etc.
See PerlTraining.Stonehenge.com for onsite and open-enrollment Perl training!

_______________________________________________
templates mailing list
templates@xxxxxxxxxxxxxxxx.xxx
http://lists.template-toolkit.org/mailman/listinfo/templates