Re: [PATCH] give us more temporary column groups

[prev] [thread] [next] [Date index for 2004/12/12]

On Sun, 12 Dec 2004, Tony Bowden wrote:
> On Sun, Dec 12, 2004 at 05:54:28PM +0000, Aaron Trevena wrote:
>> Therefore we would like to have any column group that starts with __TEMP
>> to be treated the same as TEMP.
>
> I'm happy with the idea, but not with the patch, as there is also code
> like this is Class::DBI::Column that will need likewise changed.

The idea is more important to me than the patch, so that's ok :)

> It seems to me that the best approach here would be to add an
> is_temporary() method to ColumnGrouper and fix the rest of the code to
> use that.

Right, that makes sense. Will look at that during the week.

> Tests are always nice too :)

yes, tests are good.

A.

        -- 
        Aaron J Trevena - Perl Hacker, Kung Fu Geek, Internet Consultant
AutoDia --- Automatic UML and HTML Specifications from Perl, C++ 
and Any Datasource with a Handler.     http://droogs.org/autodia