Re: patch Re: trigger documentation bug?

[prev] [thread] [next] [Date index for 2004/12/23]

On Wed, 22 Dec 2004, Tim Bunce wrote:
> diff -C (context) is the one to use.

No problem:

apocalypse.OCF.Berkeley.EDU [187] diff -C DBI.pm MyDBI.pm
diff: use -C num
apocalypse.OCF.Berkeley.EDU [188] diff -C 3 DBI.pm MyDBI.pm
*** DBI.pm	Fri Apr 30 00:22:12 2004
--- MyDBI.pm	Wed Dec 22 14:28:22 2004
***************
*** 1783,1796 ****
   	select              (also used for inflation and by construct and 
_flesh)

   You can create any number of triggers for each point, but you cannot
! specify the order in which they will be run. Each will be passed the
! object being dealt with (whose values you may change if required),
! and return values will be ignored.

! All triggers are passed the object they are being fired for.
! Some triggers are also passed extra parameters as name-value pairs.
! The individual triggers are documented with the methods that trigger them.

   =head1 CONSTRAINTS

   	__PACKAGE__->add_constraint('name', column => \&check_sub);
--- 1783,1799 ----
   	select              (also used for inflation and by construct and 
_flesh)

   You can create any number of triggers for each point, but you cannot
! specify the order in which they will be run.

! All triggers are passed the object they are being fired for, except
! when C<before_set_$column> is fired during L</create>, in which case the
! class is passed in place of the object, which does not yet exist.  You
! may change object values if required.

+ Some triggers are also passed extra parameters as name-value
+ pairs. The individual triggers are further documented with the methods
+ that trigger them.
+
   =head1 CONSTRAINTS

   	__PACKAGE__->add_constraint('name', column => \&check_sub);
***************
*** 1973,1982 ****
   The set() method calls normalize_column_values() then
   validate_column_values() before storing the values.  The
   C<before_set_$column> trigger is invoked by validate_column_values(),
! checking any constraints that may have been set up. The
! C<after_set_$column> trigger is invoked after the new value has been
! stored.

   It is possible for an object to not have all its column data in memory
   (due to lazy inflation).  If the get() method is called for such a column
   then it will select the corresponding group of columns and then invoke
--- 1976,1990 ----
   The set() method calls normalize_column_values() then
   validate_column_values() before storing the values.  The
   C<before_set_$column> trigger is invoked by validate_column_values(),
! checking any constraints that may have been set up. When called on an
! existing object, C<before_set_$column> is passed: ($self, ! $new_value => 
{$column => $new_value}). When called during L</create>,
! C<before_set_$column> is passed: ($class, $new_value => {$column =>
! $new_value, %other_columns_with_values}).

+ The C<after_set_$column> trigger is invoked after the new value has
+ been stored.
+
   It is possible for an object to not have all its column data in memory
   (due to lazy inflation).  If the get() method is called for such a column
   then it will select the corresponding group of columns and then invoke