Re: AIM/mp2 Apache::compat bug?

[prev] [thread] [next] [Date index for 2004/11/23]

Malcolm J Harwood wrote:
> On Tuesday 23 November 2004 11:56 am, Stas Bekman wrote:
> 
> 
>>>>with mp2 you need to update the stat info yourself each time you update
>>>>$r->filename. something like this:
>>>>
>>>> $r->filename($newfile);
>>>> $r->finfo(APR::Finfo::stat($newfile, APR::FINFO_NORM, $r->pool));
> 
> 
>>I've updated the docs to mention that:
>>http://perl.apache.org/docs/2.0/api/Apache/RequestRec.html#C_filename_
> 
> 
> Out of curiosity, what was the reason for the change? I would have thought it 
> is much more prone to user error (people not knowing or forgetting to update 
> the states). Are there cases where you'd change the filename but not need to 
> restat it?

if you change $r->filename in a PerlTransHandler then the default
map-to-storage handler will do the stat for you.  so, you should only need
the additional stat call after map-to-storage runs (such as from a
PerlFixupHandler).

--Geoff

        -- 
        Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html