Re: AIM/mp2 Apache::compat bug?

[prev] [thread] [next] [Date index for 2004/11/29]

Geoffrey Young wrote:
>>>what _does_ need to happen, though, is for Apache::compat to redefine
>>>filename() so that it behaves like mp1 did.  I just don't have the
>>>tuits at
>>>the moment.
>>
>>
>>Right, but there are issues with doing that:
>>
>>1) that should probably be overridable and not loaded by default:
>>http://perl.apache.org/docs/2.0/api/Apache/compat.html#Compatibility_Functions_Colliding_with_mod_perl_2_0_API
>>
>>since if not it'll replace the real mp2 API and may be someone doesn't
>>want the stat struct to be updated.
> 
> 
> yup.
> 
> 
>>2) filename() should behave differently depending on which phase was it
>>called from. What if someone just sets filename() to skip the stat
>>calls? Should it still call the finfo update?
> 
> 
> I'd think so - this is a compat layer, and mod_perl updated finfo blindly on
> each $r->filename call.  it also updated _ with the new stat information, so
> compat.pm should do that as well.

Now fixed in Apache::compat. The docs will be updated shortly.


        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com

-- 
Report problems: http://perl.apache.org/bugs/
Mail list info: http://perl.apache.org/maillist/modperl.html
List etiquette: http://perl.apache.org/maillist/email-etiquette.html