Re: [ANNOUNCE] mod_perl 2.0.0-RC5

[prev] [thread] [next] [Date index for 2005/04/15]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

The reason to flip the lines is simply that you if you require mod_perl
before you modify the @INC using Apache2 the wrong mod_perl (the one of
mp1 is found). But that should be obvious, not?

Tom

Tom Schindl schrieb:
| and here against current svn-trunk.
|
| Tom
|
| Tom Schindl schrieb:
| | The patch I submitted was against the Makefile.PL included into the
| | distro rc5 and there it read the following:
| |
| | --------------------8<--------------------
| | my $old_mp2 = eval { require Apache2 };
| | require mod_perl;
| | if( .... ) {
| | ....
| | }
| | --------------------8<--------------------
| |
| | Philip M. Gollucci schrieb:
| | | Tom Schindl wrote:
| | | Index: Makefile.PL
| | | ===================================================================
| | | --- Makefile.PL (revision 161423)
| | | +++ Makefile.PL (working copy)
| | | @@ -14,8 +14,8 @@
| | |  BEGIN {
| | |      eval {
| | |          require mod_perl;
| | | +        if ($mod_perl::VERSION < 1.999_22 && $old_mp2) {
| | |          my $old_mp2 = eval { require Apache2 };
| | | -        if ($mod_perl::VERSION < 1.999_22 && $old_mp2) {
| | |              $old_modperl_version = $mod_perl::VERSION;
| | |              $old_modperl_pm = delete $INC{'mod_perl.pm'};
| | |          }
| | | That can't work for at least 1 reason:
| | | in the if() $old_mp2 is going to cause an undefined variable
| | | error messasge thus causing the if's code to _never_ be executed
as the
| | | error will be caught by the eval.
| | |
| | |
| | | I'll try to duplicate this soonish error locally soonish.
| | |
| | | HTH
| | |
| | |
| |

- ------------------------------------------------------------------------

Index: Makefile.PL
===================================================================
- --- Makefile.PL	(Revision 161424)
+++ Makefile.PL	(Arbeitskopie)
@@ -13,8 +13,8 @@

~ BEGIN {
~     eval {
+        my $old_mp2 = eval { require Apache2 };
~         require mod_perl;
- -        my $old_mp2 = eval { require Apache2 };
~         if ($mod_perl::VERSION < 1.999_22 && $old_mp2) {
~             $old_modperl_version = $mod_perl::VERSION;
~             $old_modperl_pm = delete $INC{'mod_perl.pm'};

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.0 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://enigmail.mozdev.org

iD8DBQFCX4i6kVPeOFLgZFIRAopQAJoDboorwC+r0glUqiGd2LSFGxP1BQCfdCxF
iIVTj+3n58JxY6w0TUsmShI=
=FafG
-----END PGP SIGNATURE-----