Re: [ANNOUNCE] mod_perl 2.0.0-RC6

[prev] [thread] [next] [Date index for 2005/05/05]

From: Stas Bekman
Subject: Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Date: 14:35 on 05 May 2005

Steve Hay wrote:
> Stas Bekman wrote:
> 
> 
>>Markus Wichitill wrote:
>> 
>>
>>
>>>Steve Hay wrote:
>>>
>>>   
>>>
>>>
>>>>Almost all OK on Win32 (Apache 2.0.54 and a recent bleadperl).  Main 
>>>>tests are all successful, but ModPerl-Registry tests failed 404.t test 
>>>>1 and redirect.t test 2.
>>>>     
>>>>
>>>
>>>Same here (WinXP, 2.0.54, 5.8.6). modperl_slurp_filename doesn't raise a 
>>>ENOENT exception when it should. The
>>>
>>>   if (!size) {
>>>       sv_setpvn(sv, "", 0);
>>>       return newRV_noinc(sv);
>>>   }
>>>
>>>part looks fishy to me. size is 0 and therefore we never get to 
>>>SLURP_SUCCESS("opening"), which should throw the exception.
>>>   
>>>
>>
>>Hmm, please see the comment:
>>
>>    /* XXX: could have checked whether r->finfo.filehand is valid and
>>     * save the apr_file_open call, but apache gives us no API to
>>     * check whether filehand is valid. we can't test whether it's
>>     * NULL or not, as it may contain garbagea
>>     */
>>
>>how can we test if the filehandle is valid then? may be we should skip 
>>that bit altogether? Steve, does it work if you comment out the whole
>>
>>  if (!size) { ... }
>>
>>block?
>>
> 
> No, it doesn't :(
> 
> I even did a complete rebuild in case something didn't get relinked 
> properly after the change, but it still doesn't fix the two test failures.

So what has changed? You didn't have these problems with RC6? Could you 
trace what change has affected that? Unless Randy or someone who can 
reproduce that can look at the issue.

        -- 
        __________________________________________________________________
Stas Bekman            JAm_pH ------> Just Another mod_perl Hacker
http://stason.org/     mod_perl Guide ---> http://perl.apache.org
mailto:stas@xxxxxx.xxx http://use.perl.org http://apacheweek.com
http://modperlbook.org http://apache.org   http://ticketmaster.com