Re: [ANNOUNCE] mod_perl 2.0.0-RC6

[prev] [thread] [next] [Date index for 2005/05/06]

From: Randy Kobes
Subject: Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Date: 13:29 on 06 May 2005
On Fri, 6 May 2005, Steve Hay wrote:

> Markus Wichitill wrote:
[ .. ]
> >
> >I guess you two didn't remove the "if (!size)" check like I did?
> >
> Shit.  How dumb am I?
>
> You're absolutely right -- you have to remove the size
> check as well in order for Randy's fix to even be reached!
> With this change in place too I now have all tests
> successful :-)
>
> Thanks, Markus!
> - Steve

I forgot too to do that ... Would the following be OK?

Index: src/modules/perl/modperl_util.c
===================================================================
--- src/modules/perl/modperl_util.c	(revision 168597)
+++ src/modules/perl/modperl_util.c	(working copy)
@@ -616,10 +616,12 @@
     size = r->finfo.size;
     sv = newSV(size);

+    /* allow SLURP_SUCCESS() below an opportunity to set error
     if (!size) {
         sv_setpvn(sv, "", 0);
         return newRV_noinc(sv);
     }
+    */

     /* XXX: could have checked whether r->finfo.filehand is valid and
      * save the apr_file_open call, but apache gives us no API to
==========================================================

Or would it be better to wrap the if(!size) { } within
an #ifndef WIN32?

        -- 
        best regards,
randy

(message missing)

[ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 06:26 on 04 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Octavian Rasnita 09:47 on 04 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 02:34 on 10 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Steve Hay 10:36 on 04 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Markus Wichitill 13:44 on 04 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 06:40 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Steve Hay 09:28 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 14:35 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Markus Wichitill 14:47 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Randy Kobes 15:25 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Steve Hay 16:00 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Markus Wichitill 16:13 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Randy Kobes 16:54 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Steve Hay 17:08 on 05 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 05:27 on 06 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Randy Kobes 05:40 on 06 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Markus Wichitill 10:11 on 06 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Steve Hay 10:31 on 06 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Randy Kobes 13:29 on 06 May 2005

Graphics / Pie Charts
David Hofmann 19:34 on 06 May 2005

Re: Graphics / Pie Charts
Sam Tregar 19:40 on 06 May 2005

Re: Graphics / Pie Charts
Hans Poo 21:01 on 06 May 2005

Re: Graphics / Pie Charts
Jeff Ambrosino 21:31 on 06 May 2005

Re: Graphics / Pie Charts
Jay Scherrer 23:57 on 06 May 2005

Re: Graphics / Pie Charts
Foo Ji-Haw 05:47 on 07 May 2005

Re: Graphics / Pie Charts
Tom Schindl 13:07 on 07 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Tom Williams 19:43 on 07 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 07:16 on 08 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Tom Williams 14:21 on 08 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 15:11 on 08 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 02:00 on 10 May 2005

Re: [ANNOUNCE] mod_perl 2.0.0-RC6
Stas Bekman 06:50 on 07 May 2005

Generated at 06:57 on 17 May 2005 by mariachi v0.52