Re: PATCH: add_trigger()

[prev] [thread] [next] [Date index for 2004/09/30]

From: Tony Bowden
Subject: Re: PATCH: add_trigger()
Date: 21:20 on 30 Sep 2004
On Thu, Sep 30, 2004 at 03:59:43PM -0400, Drew Taylor wrote:
> It would be very nice to have checking in add_trigger() which makes
> sure you're using a valid trigger. Version 0.96 doesn't have this
> functionality, so a stab at it is below. I don't have a handy recent
> perl available to test the patch so I apologize if I've done something
> stupid. I did update the docs but not t/11-triggers.t (but I will if
> Tony is interested).

I believe we can do this just by passing the valid trigger names to  
Class::Trigger at import:

use Class::Trigger qw/before_create after_create before_update
  after_update before_delete after_delete select create/;

I'm not sure this plays out if you want to add other trigger points
of your own, though. But I'm sure Miyagawa will be open to patches for
that :)

Tony

(message missing)

PATCH: add_trigger()
Drew Taylor 19:59 on 30 Sep 2004

Re: PATCH: add_trigger()
Tony Bowden 21:20 on 30 Sep 2004

Re: PATCH: add_trigger()
Edward J. Sabol 21:42 on 30 Sep 2004

Re: PATCH: add_trigger()
Drew Taylor 22:15 on 30 Sep 2004

Re: PATCH: add_trigger()
Edward J. Sabol 22:21 on 30 Sep 2004

Re: PATCH: add_trigger()
Drew Taylor 13:51 on 01 Oct 2004

Re: PATCH: add_trigger()
Tony Bowden 14:06 on 01 Oct 2004

Re: PATCH: add_trigger()
Edward J. Sabol 15:16 on 01 Oct 2004

Re: PATCH: add_trigger()
Drew Taylor 14:12 on 01 Oct 2004

Generated at 11:34 on 01 Dec 2004 by mariachi v0.52