Re: PATCH: add_trigger()

[prev] [thread] [next] [Date index for 2004/09/30]

On Thu, 30 Sep 2004 22:20:22 +0100, Tony Bowden <tony-cdbitalk@xxxxx.xxx> wrote:
> On Thu, Sep 30, 2004 at 03:59:43PM -0400, Drew Taylor wrote:
> > It would be very nice to have checking in add_trigger() which makes
> > sure you're using a valid trigger. Version 0.96 doesn't have this
> > functionality, so a stab at it is below. I don't have a handy recent
> > perl available to test the patch so I apologize if I've done something
> > stupid. I did update the docs but not t/11-triggers.t (but I will if
> > Tony is interested).
> 
> I believe we can do this just by passing the valid trigger names to
> Class::Trigger at import:
 
Good idea.

> I'm not sure this plays out if you want to add other trigger points
> of your own, though. 

We could always have a mutator to add to the standard trigger points.
It might be a good thing to have your application level triggers
documented somewhere. :-)

Drew
        -- 
        ----------------------------------------------------------------
 Drew Taylor                 *  Web development & consulting
 Email: drew@xxxxxxxxxx.xxx  *  Site implementation & hosting
 Web  : www.drewtaylor.com   *  perl/mod_perl/DBI/mysql/postgres
 ----------------------------------------------------------------