Re: No overload magic

[prev] [thread] [next] [Date index for 2005/02/17]

From: William Ross
Subject: Re: No overload magic
Date: 14:20 on 17 Feb 2005
On 16 Feb 2005, at 11:25, Michael G Schwern wrote:

> On Wed, Feb 16, 2005 at 10:05:41AM +0000, William Ross wrote:
>> In the message you cite the author was trying to perform comparisons 
>> on
>> cdbi objects and assuming that ($x > $y) is the same as ($x->id >
>> $y->id). There's no reason why that assumption should be correct: not
>> all classes have a single key, and it's just as likely that you would
>> want to compare some other column or a computed value, so cdbi leaves
>> you to specify your own overloading.
>
> I think that's a bit silly. [1]  Its not as likely you want to compare 
> some
> other column, you probably want to compare the primary keys especially
> when its an equality test.  CDBI can do the right thing by default for
> $x == $y even in the case of multiple primary keys.  Its an expectation
> that was added and now appears to have been removed?

As far as I know == still works this way. The original poster was 
expecting > to be the same, which at the moment it isn't.

It's interesting to note that the overloading of == also means that

	Class::A->retrieve($id) == Class::B->retrieve($id)

will be true, provided they exist. Is this good, bad or irrelevant?

will

No overload magic
Karjala 07:55 on 16 Feb 2005

Re: No overload magic
Karjala 08:01 on 16 Feb 2005

Re: No overload magic
William Ross 10:05 on 16 Feb 2005

Re: No overload magic
Michael G Schwern 11:25 on 16 Feb 2005

Re: No overload magic
Tony Bowden 14:10 on 16 Feb 2005

Re: No overload magic
William Ross 14:20 on 17 Feb 2005

Re: No overload magic
Michael G Schwern 06:43 on 18 Feb 2005

Re: No overload magic
Tony Bowden 08:21 on 18 Feb 2005

Re: No overload magic
Tim Bunce 09:43 on 18 Feb 2005

Re: No overload magic
Karjala 11:57 on 16 Feb 2005

Re: No overload magic
William Ross 13:52 on 16 Feb 2005

Re: No overload magic
Karjala 14:09 on 16 Feb 2005

Re: No overload magic
Michele Valzelli 11:59 on 16 Feb 2005

Re: No overload magic
Ofer Nave 21:53 on 16 Feb 2005

Re: No overload magic
Ken.Olstad 22:00 on 16 Feb 2005

Generated at 11:20 on 20 Feb 2005 by mariachi v0.52