Re: search() without search criteria

[prev] [thread] [next] [Date index for 2005/04/29]

From: Perrin Harkins
Subject: Re: search() without search criteria
Date: 14:25 on 29 Apr 2005

Will Hawes wrote:
> This works fine when search criteria are specified:
> 
> $class->search(column1 => value, {rows => 10});

Really?  What are you using?  Class::DBI doesn't support that, as far as 
I can see.  Are you using one of the subclasses that has LIMIT support 
added?

> I'm aware there are probably workarounds - using retrieve_all() to return an iterator is one that springs to mind, a custom constructor is another - but I want to avoid returning whole result sets into memory or, worse, writing custom SQL.

Well, search() does load the whole result set into memory...

> I'd like to hear opinions regarding a patch to Class::DBI so that search() accepts an empty hash as the first argument.

A better approach would be to just make search() call retrieve_all() 
when it gets no arguments for columns.  Making retrieve use LIMIT (or 
equivalent) is no harder than making search() do it.  I hacked it into 
the base class we use here a while back.

- Perrin