Re: prefixing table names?

[prev] [thread] [next] [Date index for 2004/11/02]

I replaced my hack in Class::DBI::DATA::Schema::import with something 
slightly better:

                my $prefix = $caller->TABLE_PREFIX() || '';
                $sql =~ s/(CREATE TABLE IF NOT EXISTS) /$+ $prefix/sg;

I also put a sub table() in Email::Store::DBI that would applies the 
prefix in one place, like so:

sub table {
         my ($class, $table_name)  = @_;
         my $prefix = __PACKAGE__->TABLE_PREFIX();
	# sometimes table() is called with a null $table_name
	#   in this case, be sure to leave $table_name null
         $table_name = $prefix.$table_name
		unless( $table_name =~ /^$prefix/
		or $table_name eq '' );
         $class->SUPER::table($table_name)
}
instead of doing this in each object package:
   Email::Store::Mail->table(__PACKAGE__->TABLE_PREFIX() . "mail"); # feh

This only leftover crud is in Email::Store::Entity:

##############
# BOWEN - HACK
my $sql = q{
     SELECT     DISTINCT entity id
     FROM TABLE_PREFIX_addressing
     WHERE name = ?    AND address = ?};
my $prefix = Email::Store::DBI->TABLE_PREFIX();
$sql =~ s/TABLE_PREFIX_/$prefix/sg;
Email::Store::Entity->set_sql(distinct_entity => $sql);
##############

any clues?

Bowen Dwelle wrote:
> The only real ugliness so far is when Class::DBI::DATA::Schema is used 
> to create tables... For now I have this hard-coded, can someone advise 
> how to look in the right place in the calling stack?
> 
>     my $prefix = Email::Store::DBI->TABLE_PREFIX();
>     $sql =~ s/TABLE_PREFIX_/$prefix/sg;
> 
> thx
> 
> -- Bowen
> 
> Bowen Dwelle wrote:
> 
>> Bradley K. Embree wrote:
>>
>>> Could you not set up a TABLE_PREFIX in a parent CDBI class and have 
>>> your other classes inherit from that? The problem with this is 
>>> needing to be extra careful when rolling your own SQL to use the 
>>> prefix where necessary. Of course the __TABLE__ notation provided by 
>>> Ima::DBI makes that easier.
>>>
>>>
>>> package My::CDBI;
>>>
>>> sub TABLE_PREFIX {
>>>     return 'foo_';
>>> }
>>>
>>> package My::CDBI::Bar;
>>>
>>> use base 'My::CDBI';
>>>
>>> __PACKAGE__->table( __PACKAGE__->TABLE_PREFIX() . 'bar' );
>>>
>>>
>>> Hope that makes some sort of sense,
>>>
>>> Brad
>>
>>
>>
>> In this case the app uses set_up_table(), but that seems to do the 
>> same thing.
>>
>> I knew there was a simple answer. Thanks!
>>
>