Re: DBIx::ContextualFetch trouble

[prev] [thread] [next] [Date index for 2004/12/27]

On Mon, Dec 27, 2004 at 04:54:49PM +0200, Gabor Szabo wrote:
> That was only one problem.
> There was a whole set of other cases where the behavor was strange.
> I am attaching my test script (see the comments as well)
> Looking at the new test script you put in the distro now I understand
> that I might have misunderstood the API.

This was never the API of the module. It was just a simple helper
function in the test script.

> It seems to be strange that sometimes you call ->execute manually
> and sometimes you leave it to the module to do it. This can cause
> someone to accidently call execute twice and you don't even get
> a warning from DBIx::ContextualFetch.

There are two types of extra methods added to $sth - there are the
context sensitive versions of all the normal fetch methods. These, like
their normal DBI counterparts, require you to call execute() first.

The helper function was written with these in mind.

Then there are the (undocumented) select_row / select_col / select_val
methods. These let you do everything in one command, and don't require
execute() first.

The tests for these proceeded to use the pre-executed helper function,
when they shouldn't have.

This has all now been tidied up.

If you believe there's still a problem here, please put together a new
test script that uses the helper function that's currently in the test.

Thanks,

Tony