Re: Class::DBI 0.96 and perl 5.8.3 - bad combo?

[prev] [thread] [next] [Date index for 2005/04/11]

* Dave Howorth shaped the electrons to say...

>>>cpepc210-1:~/.cpan/build/Class-DBI-0.96 # make test
>>>...snip...
>>>t/16-reserved.........ok 2/5Argument "Bad Taste" isn't numeric in 
>>>subroutine entry at 
>>
>>
>>What version of DBD::SQLite are you using?
>
>The file says:
># $Id: SQLite.pm,v 1.44 2004/09/10 15:25:46 matt Exp $
>$VERSION = '1.05';
>
>but when I go into cpan:

Multiple versions installed maybe? I ask, because I've seen that "isn't
numeric in.." with 1.08 - Matt doesn't think it's a problem however.

My fix was:

diff -ru DBD-SQLite-1.08/dbdimp.c DBD-SQLite-1.08.fixed/dbdimp.c
--- DBD-SQLite-1.08/dbdimp.c	Tue Feb 22 08:09:23 2005
+++ DBD-SQLite-1.08.fixed/dbdimp.c	Mon Feb 28 23:23:59 2005
@@ -357,7 +357,7 @@
             char * data = SvPV(value, len);
             retval = sqlite3_bind_blob(imp_sth->stmt, i+1, data, len, SQLITE_TRANSIENT);
         }
-        else if (looks_like_number(value)) {
+        else if (SvNIOK(value)) {
             /* bind ordinary numbers as numbers - otherwise we might sort wrong */
             retval = sqlite3_bind_double(imp_sth->stmt, i+1, SvNV(value));
         }

-D
        -- 
        I'm really looking forward to this hangover.